Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing options to asyncIterableIterator #278

Open
boehlkers opened this issue Nov 20, 2024 · 0 comments
Open

Support passing options to asyncIterableIterator #278

boehlkers opened this issue Nov 20, 2024 · 0 comments

Comments

@boehlkers
Copy link

boehlkers commented Nov 20, 2024

Thanks for the new 3.0.0 release! I'm trying to use 3.0.0 now instead of the asyncIterator implementation in graphql-redis-subscriptions, in implementing redis subscriptions; however, the pubsubAsyncIterator class implemented here does not have an ability to pass options through from the constructor through to the underlying pubsub.subscribe call.

Could we add a third argument to the constructor of PubSubAsyncIterableIterator (and the associated asyncIterableIterator function in PubSubEngine) which passes options through to the underlying subscribe call? This would mirror the capabilities provided by subscribe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant