PRO-6835: Determine Best AssetUrl is in easy mode with the new build …

…system (#4814)
apostrophecms · Nov 23, 2024 · e05027b · e05027b
1 parent e8c1c9e
commit e05027b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## UNRELEASED
+
+### Fixes
+
+* Fixes broken widget preview URL when the image is overridden (module improve) and external build module is registered.
+
 ## 4.10.0 (2024-11-20)
 
 ### Fixes

diff --git a/modules/@apostrophecms/module/index.js b/modules/@apostrophecms/module/index.js
@@ -818,7 +818,8 @@ module.exports = {
         let urlOption = self.options[`${name}Url`];
         const imageOption = self.options[`${name}Image`];
         if (!urlOption) {
-          if (imageOption) {
+          // Webpack and the legacy asset pipeline
+          if (imageOption && !self.apos.asset.hasBuildModule()) {
             const chain = [ ...self.__meta.chain ].reverse();
             for (const entry of chain) {
               const path = `${entry.dirname}/public/${name}.${imageOption}`;
@@ -828,6 +829,10 @@ module.exports = {
               }
             }
           }
+          // The new external module asset pipeline
+          if (imageOption && self.apos.asset.hasBuildModule()) {
+            urlOption = `/modules/${self.__meta.name}/${name}.${imageOption}`;
+          }
         }
         if (urlOption && urlOption.startsWith('/modules')) {
           urlOption = self.apos.asset.url(urlOption);