Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename projection into options #4259

Merged
merged 1 commit into from
Aug 9, 2023
Merged

rename projection into options #4259

merged 1 commit into from
Aug 9, 2023

Conversation

haroun
Copy link
Contributor

@haroun haroun commented Aug 8, 2023

Summary

Rename misleading projection parameter into options

What are the specific steps to test this change?

  1. Check the code change
  2. Check that the integration tests are green

What kind of change does this PR introduce?

(Check at least one)

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@haroun haroun requested a review from boutell August 8, 2023 13:54
@haroun haroun self-assigned this Aug 8, 2023
@linear
Copy link

linear bot commented Aug 8, 2023

PRO-4502 Related content at the bottom of articles is missing after upgrade to Apostrophe 3

This is a migration issue, because the relationships between the articles and this component of the template are broken. The component itself works in that you can select articles manually, but this means Utah would have to manually reselect the articles in order for it to be better. So what we should look into is rerunning the migration process. We will need the DB dump. The one we have at the moment is the one where the migration is done already.

It sounds like there was a related content widget or template component that pulled in content based on tag (we should find out exactly how it worked), and that isn't working after the upgrade and content migration. It might have something to do with the missing Categories / tags, but not sure.

@boutell boutell merged commit f4cb69a into main Aug 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants