PRO-6684 cointext menus focus trap [a11y] #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myovchev
commented
Nov 14, 2024
| @@ -17,6 +17,7 @@ | |||
| :label="selectBoxMessageButton" | |||
| class="apos-select-box__select-all" | |||
| text-color="var(--a-primary)" | |||
| :disabled="!showSelectAll" | |||
There was a problem hiding this comment.
Required because the buttons are getting selected when trapping focus, but they are also hidden.
stuartromanek
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
The UX of these changes feels great .. @ETLaurent might want to take a look, as one who broke ground on the focus trapping work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Trap focus and cycle in the focusable elements in context menus.
What are the specific steps to test this change?
Filter menu in e.g. Pieces Manager should be focusable by keyboard only and should offer the expected UX.
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: