Bump deps #561
Annotations
17 warnings
assigning the result of `Clone::clone()` may be inefficient:
store/src/local/mutation_index/query.rs#L526
warning: assigning the result of `Clone::clone()` may be inefficient
--> store/src/local/mutation_index/query.rs:526:17
|
526 | part.field = part.text.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `part.field.clone_from(&part.text)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
usage of a legacy numeric constant:
store/src/local/entity_index/mod.rs#L578
warning: usage of a legacy numeric constant
--> store/src/local/entity_index/mod.rs:578:66
|
578 | let block_offset = result.block_offset.unwrap_or(std::u64::MAX);
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
578 | let block_offset = result.block_offset.unwrap_or(u64::MAX);
| ~~~~~~~~
|
assigning the result of `Clone::clone()` may be inefficient:
store/src/local/entity_index/iterator.rs#L133
warning: assigning the result of `Clone::clone()` may be inefficient
--> store/src/local/entity_index/iterator.rs:133:17
|
133 | entity_id = next_id.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `entity_id.clone_from(next_id)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
|
usage of a legacy numeric constant:
store/src/local/entity_index/aggregator.rs#L188
warning: usage of a legacy numeric constant
--> store/src/local/entity_index/aggregator.rs:188:67
|
188 | if current_operation_id > last_operation_id.unwrap_or(std::u64::MIN) {
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` on by default
help: use the associated constant instead
|
188 | if current_operation_id > last_operation_id.unwrap_or(u64::MIN) {
| ~~~~~~~~
|
assigning the result of `Clone::clone()` may be inefficient:
store/src/local/entity_index/aggregator.rs#L115
warning: assigning the result of `Clone::clone()` may be inefficient
--> store/src/local/entity_index/aggregator.rs:115:13
|
115 | entity_id = current_mutation.entity_id.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `entity_id.clone_from(¤t_mutation.entity_id)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
|
field `remaining` is never read:
store/src/local/mutation_index/results.rs#L61
warning: field `remaining` is never read
--> store/src/local/mutation_index/results.rs:61:9
|
58 | pub struct MutationResults {
| --------------- field in this struct
...
61 | pub remaining: usize,
| ^^^^^^^^^
|
field `matched_mutation` is never read:
store/src/local/entity_index/searcher.rs#L285
warning: field `matched_mutation` is never read
--> store/src/local/entity_index/searcher.rs:285:9
|
284 | pub struct SearchResult {
| ------------ field in this struct
285 | pub matched_mutation: MutationMetadata,
| ^^^^^^^^^^^^^^^^
|
field `last_block_offset` is never read:
store/src/local/entity_index/aggregator.rs#L59
warning: field `last_block_offset` is never read
--> store/src/local/entity_index/aggregator.rs:59:9
|
28 | pub struct EntityAggregator {
| ---------------- field in this struct
...
59 | pub last_block_offset: Option<BlockOffset>,
| ^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
usage of a legacy numeric constant:
chain/src/chain/mod.rs#L74
warning: usage of a legacy numeric constant
--> chain/src/chain/mod.rs:74:45
|
74 | let to_offset = to_offset.unwrap_or(std::u64::MAX);
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
74 | let to_offset = to_offset.unwrap_or(u64::MAX);
| ~~~~~~~~
|
usage of a legacy numeric constant:
chain/src/chain/mod.rs#L73
warning: usage of a legacy numeric constant
--> chain/src/chain/mod.rs:73:49
|
73 | let from_offset = from_offset.unwrap_or(std::u64::MIN);
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
73 | let from_offset = from_offset.unwrap_or(u64::MIN);
| ~~~~~~~~
|
importing legacy numeric constants:
chain/src/chain/directory/tracker.rs#L7
warning: importing legacy numeric constants
--> chain/src/chain/directory/tracker.rs:7:5
|
7 | usize,
| ^^^^^
|
= help: remove this import
= note: then `usize::<CONST>` will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` on by default
|
file opened with `create`, but `truncate` behavior not defined:
chain/src/chain/directory/segment.rs#L372
warning: file opened with `create`, but `truncate` behavior not defined
--> chain/src/chain/directory/segment.rs:372:14
|
372 | .create(true)
| ^^^^^^^^^^^^- help: add: `.truncate(true)`
|
= help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
= help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
= help: alternatively, use `.append(true)` to append to the file instead of overwriting it
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
= note: `#[warn(clippy::suspicious_open_options)]` on by default
|
field `0` is never read:
chain/src/chain/directory/tracker.rs#L163
warning: field `0` is never read
--> chain/src/chain/directory/tracker.rs:163:10
|
163 | Read(Arc<memmap2::Mmap>),
| ---- ^^^^^^^^^^^^^^^^^^
| |
| field in this variant
|
= note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
163 | Read(()),
| ~~
|
assigning the result of `Clone::clone()` may be inefficient:
transport/src/messages.rs#L86
warning: assigning the result of `Clone::clone()` may be inefficient
--> transport/src/messages.rs:86:9
|
86 | msg.connection = self.connection.clone();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `msg.connection.clone_from(&self.connection)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
= note: `#[warn(clippy::assigning_clones)]` on by default
|
file opened with `create`, but `truncate` behavior not defined:
core/src/simple_store/json_disk_store.rs#L56
warning: file opened with `create`, but `truncate` behavior not defined
--> core/src/simple_store/json_disk_store.rs:56:14
|
56 | .create(true)
| ^^^^^^^^^^^^- help: add: `.truncate(true)`
|
= help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
= help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
= help: alternatively, use `.append(true)` to append to the file instead of overwriting it
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
|
file opened with `create`, but `truncate` behavior not defined:
core/src/dir/os.rs#L54
warning: file opened with `create`, but `truncate` behavior not defined
--> core/src/dir/os.rs:54:14
|
54 | .create(true)
| ^^^^^^^^^^^^- help: add: `.truncate(true)`
|
= help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
= help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
= help: alternatively, use `.append(true)` to append to the file instead of overwriting it
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
= note: `#[warn(clippy::suspicious_open_options)]` on by default
|
field `0` is never read:
core/src/sec/keys.rs#L20
warning: field `0` is never read
--> core/src/sec/keys.rs:20:15
|
20 | Secp256k1(libp2p_secp256k1::Keypair),
| --------- ^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| field in this variant
|
= note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
20 | Secp256k1(()),
| ~~
|