Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming Status enums to avoid clashes #35

Closed
vpavic opened this issue Sep 14, 2023 · 1 comment
Closed

Consider renaming Status enums to avoid clashes #35

vpavic opened this issue Sep 14, 2023 · 1 comment

Comments

@vpavic
Copy link
Contributor

vpavic commented Sep 14, 2023

The project contains 2 enums named Status:

  • com.apple.itunes.storekit.model.Status
  • com.apple.itunes.storekit.verification.Status

This is unfortunate because if one needs to use both in the same class, one has to be referred to with fully-qualified class name.

Perhaps these enums could be renamed to be more specific (for example, SubscriptionStatus and VerificationStatus)?
@alexanderjordanbaker
Copy link
Collaborator

Resolved in #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vpavic @alexanderjordanbaker