Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #42

Closed
vpavic opened this issue Sep 25, 2023 · 5 comments
Closed

Improve test coverage #42

vpavic opened this issue Sep 25, 2023 · 5 comments

Comments

@vpavic
Copy link
Contributor

vpavic commented Sep 25, 2023

As evident by some recent issues like #32 and #37, test coverage in this project is quite low.

For example, SignedDataVerifier only verifies test notification type and not others that are truly relevant and ReceiptUtility is completely untested.

@alexanderjordanbaker
Copy link
Collaborator

Hello @vpavic we have now increased our test coverage and aim to test all major flows in some recent PRs to add additional coverage.

@alexanderjordanbaker
Copy link
Collaborator

This was resolved in #51

@vpavic
Copy link
Contributor Author

vpavic commented Nov 14, 2023

Thanks for the update @alexanderjordanbaker, I just went through all the changes that were merged over the past few weeks and the situation is now indeed better.

I'd just suggest to add some more test cases for server notifications, because the only tested notification is one of type TEST and those don't really have much data on them and therefore do not adequately test the whole decoding and verification functionality.

@alexanderjordanbaker
Copy link
Collaborator

@vpavic I think this is the test you are looking for, it does a more comprehensive test of the actual decoding of notifications https://github.com/apple/app-store-server-library-java/blob/main/src/test/java/com/apple/itunes/storekit/model/ResponseBodyV2DecodedPayloadTest.java

The tests treat the verification pieces (x5c header that kind of thing) separately from the making sure the model decoding is correct

@vpavic
Copy link
Contributor Author

vpavic commented Dec 22, 2023

Thanks, I missed that one, it indeed is what I was looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants