-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test coverage #42
Comments
Hello @vpavic we have now increased our test coverage and aim to test all major flows in some recent PRs to add additional coverage. |
This was resolved in #51 |
Thanks for the update @alexanderjordanbaker, I just went through all the changes that were merged over the past few weeks and the situation is now indeed better. I'd just suggest to add some more test cases for server notifications, because the only tested notification is one of type |
@vpavic I think this is the test you are looking for, it does a more comprehensive test of the actual decoding of notifications https://github.com/apple/app-store-server-library-java/blob/main/src/test/java/com/apple/itunes/storekit/model/ResponseBodyV2DecodedPayloadTest.java The tests treat the verification pieces (x5c header that kind of thing) separately from the making sure the model decoding is correct |
Thanks, I missed that one, it indeed is what I was looking for. |
As evident by some recent issues like #32 and #37, test coverage in this project is quite low.
For example,
SignedDataVerifier
only verifies test notification type and not others that are truly relevant andReceiptUtility
is completely untested.The text was updated successfully, but these errors were encountered: