Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable val_indices feature in user Dataset #93

Open
grananqvist opened this issue Jul 4, 2024 · 2 comments
Open

enable val_indices feature in user Dataset #93

grananqvist opened this issue Jul 4, 2024 · 2 comments
Labels
Beginner issue Has a straight-forward solution, good for new contributors

Comments

@grananqvist
Copy link
Member

The val_indices argument here https://github.com/apple/pfl-research/blob/develop/pfl/data/dataset.py#L164 is currently not implemented. fix it.
The correct behavior should be if val_indices are provided, then split method should split the user dataset into a train and val partition dataset objects according to those indices and not according to the input arguments of split.
This is useful if you have static partitions within each individual user.

(115345691)

@grananqvist grananqvist added the Beginner issue Has a straight-forward solution, good for new contributors label Jul 4, 2024
@hardlyhuman
Copy link

Hi @grananqvist I can take up this and implement if no one is working on it currently

@grananqvist
Copy link
Member Author

sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner issue Has a straight-forward solution, good for new contributors
Projects
None yet
Development

No branches or pull requests

2 participants