Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust language bingings/code generation #114

Open
WeetHet opened this issue Feb 11, 2024 · 7 comments
Open

Rust language bingings/code generation #114

WeetHet opened this issue Feb 11, 2024 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@WeetHet
Copy link

WeetHet commented Feb 11, 2024

I'm really interested in using this in my rust projects, any plans on supporting serde/code generation?

@jclmnop
Copy link

jclmnop commented Feb 12, 2024

+1 for this

In the meantime we'd have to just use serde_json and export the .pkl to .json, then manually define all the types/structs etc again in code (which I guess is what we do with JSON/YAML anyway). Would be nice to just write the config and have it generate the types for us.

@holzensp holzensp added the help wanted Extra attention is needed label Feb 13, 2024
@holzensp
Copy link
Collaborator

This is a totally valid ask and you're not the first to ask. The core team lacks bandwidth at the moment, so we can't make any promises about this in the foreseeable future. That said, community contributed Typescript bindings are approaching done after little more than a week.

If anyone wants to pick this up, I'm sure pol-community will be happy to host it (cc @jasongwartz, @jackkleeman). Support has been readily available on the discord channel they opened for this.

@jackkleeman
Copy link

I think I will probably work on this after Typescript

@linux-china
Copy link

Vote for Rusting binding:

  • Rust is friendly for JavaScript and Python: if Rust binding ready, it's easy to implement JS/Python binding, and other languages.
  • Browser friendly: WebAssembly
  • CLI friendly: now GraalVM native-image binary is 102M, maybe Rust binary is about 10M.

@jackkleeman
Copy link

jackkleeman commented Mar 1, 2024

CLI friendly: now GraalVM native-image binary is 102M, maybe Rust binary is about 10M.

This would require actually building a Pkl JIT interpreter in Rust. This is a much larger task. The goal with bindings is to create a type safe way to interact with the pkl binary (in server mode). In time, the bindings will be changed to use Pkl as a linked library instead of over exec - but this may still be quite large, and GraalVM based!

If someone wants to try and build a new interpreter for Pkl in Rust, they should absolutely go ahead, but it's definitely beyond me!

@SmolPatches
Copy link

I'm brand new to PKL so take this with a sizable pile of salt but what would a binding to Rust entail? I am quite interested in knowing what goes in to making a typesafe / production language binding.
I imagine PKL could be made to leverage json serde to encode the Pkl types into rust at runtime, obviously this could fail if the structure of the JSON is not capable of being ingested by the particular structs / enums in Rust but is that not alright, we would just need errors to provide details on the problematic code.

@z-jxy
Copy link

z-jxy commented Jun 18, 2024

I'm brand new to PKL so take this with a sizable pile of salt but what would a binding to Rust entail? I am quite interested in knowing what goes in to making a typesafe / production language binding.
I imagine PKL could be made to leverage json serde to encode the Pkl types into rust at runtime,

This does work, sort of. You could technically call pkl eval file.pkl --format json and deserialize that output, but that would be more of a wrapper around the pkl binary than a binding.

The binding should be parsing the evaluator responses according to the spec. The task is mainly turning the binary encoding into a format that can be deserialized, which would include doing most of the work serde json does.

For example, evaluating this pkl file:

address = "127.0.0.1"
database {
    username = "root"
    password = "password"
}

would produce an output like this.

A good reference for how this is implemented is pkl-go. I also have a working binding for Rust

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants