-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GracefulConnectionClosureHandlingTest failure #2117
Comments
https://github.com/apple/servicetalk/pull/2174/checks?check_run_id=5796849625
|
https://github.com/apple/servicetalk/runs/6044078838
|
|
https://github.com/apple/servicetalk/runs/6631729272
|
https://github.com/apple/servicetalk/pull/2257/checks?check_run_id=7156982960
|
https://github.com/apple/servicetalk/pull/2356/checks?check_run_id=8308215695
|
https://github.com/apple/servicetalk/actions/runs/4768582573/jobs/8478257970
|
https://github.com/apple/servicetalk/pull/2614/checks?check_run_id=13905833408
|
https://github.com/apple/servicetalk/pull/2621/checks?check_run_id=14422322949
|
https://github.com/apple/servicetalk/pull/2640/checks?check_run_id=14801441626
|
https://github.com/apple/servicetalk/actions/runs/6724690520/job/18277489377?pr=2741 This one is unique in that it failed with the HTTP_2 protocol and failed with a timeout.
|
https://github.com/apple/servicetalk/actions/runs/6897145342/job/18765420150#step:7:1342
|
These all smell similar to the problem in |
https://github.com/apple/servicetalk/pull/2799/checks?check_run_id=20544782936
|
This test is pretty easy to repro locally if you start all your cores working on something else and run it. For me, it looks like it fails about 50% of the time. I can't reproduce it with cleartext but it fails very often with TLS enabled. |
Spent some time to debug it today, and found that this happens only for The test is structured in the following way:
So far, all steps are expected. But the write fails bcz the parent channel is already closed. Somehow, it happened that
|
Debugged it a little further today. Actually, This test started to fail more frequently after we merged "disable auto read for stream channels" (#2799). The problem is that the last fired I read discussions around #9400, and those seem reasonable. An alternative fix could be to enhance |
Proposed fix for netty: netty/netty#13812 |
Will be fixed with Netty 4.1.107.Final |
Until we can upgrade netty I've put up a PR to disable the tests: #2827 |
This reverts (apple#2827), commit db9a026. Resolves apple#2117.
https://github.com/apple/servicetalk/actions/runs/11127685633/job/30920582786?pr=3071
|
https://github.com/apple/servicetalk/runs/5347779658
The text was updated successfully, but these errors were encountered: