Update protobuf build based on current cmake docs.

The docs say C++14, but builds say they need C++17.
apple · Nov 11, 2024 · 2c22056 · 2c22056
1 parent 4782e2f
commit 2c22056
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -87,10 +87,12 @@ jobs:
     - name: Build protobuf
       if: steps.cache-protobuf.outputs.cache-hit != 'true'
       working-directory: protobuf
+      # https://github.com/protocolbuffers/protobuf/blob/main/cmake/README.md#c-version
       run: |
         mkdir cmake_build
         cd cmake_build
         cmake \
+          -DCMAKE_CXX_STANDARD=17 \
           -DCMAKE_BUILD_TYPE=Release \
           -Dprotobuf_BUILD_TESTS=OFF \
           -Dprotobuf_INSTALL=OFF \

diff --git a/.github/workflows/regular_conformance.yml b/.github/workflows/regular_conformance.yml
@@ -83,10 +83,12 @@ jobs:
     - name: Build protobuf
       if: steps.cache-protobuf.outputs.cache-hit != 'true'
       working-directory: protobuf
+      # https://github.com/protocolbuffers/protobuf/blob/main/cmake/README.md#c-version
       run: |
         mkdir cmake_build
         cd cmake_build
         cmake \
+          -DCMAKE_CXX_STANDARD=17 \
           -DCMAKE_BUILD_TYPE=Release \
           -Dprotobuf_BUILD_TESTS=OFF \
           -Dprotobuf_INSTALL=OFF \