Add Sendable to more places that folks might want it.
#1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has some overlap with #1434 fyi @willtemperley |
thomasvl
force-pushed
the
more_sendable
branch
3 times, most recently
from
0fb5ce5
to
18ef553
Compare
Ensure all the Decoding/Encoding Options types are marked Sendable. There are still some places with TOOD around `Sendable`, but `Data` lack of support in 5.6 is making this a little complex to sort out.
thomasvl
force-pushed
the
more_sendable
branch
from
18ef553
to
675b617
Compare
|
I've dropped some of the attempts at making some of the extension related parts |
allevato
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The covers all places with the TODO comments from the first Sendable work.
Also ensure all the Decoding/Encoding Options types are marked Sendable.