Swap String(bytes:encoding:)! for String(decoding:as:) #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will update once #1732 is merged, as that appears to be the problem. |
Avoids the force unwraps that were needed before. From the comment in apple#1730 (comment).
thomasvl
force-pushed
the
string_decoding_as
branch
from
bd67abc
to
b164ab2
Compare
|
@Lukasa I moved over all the calls I could find per you comment on the other issue. Let me know if you want a subset of these instead. |
|
@Lukasa did you want to do this suggestion from that issue, or should I drop this? |
Lukasa
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the force unwraps that were needed before.
From the comment in #1730 (comment).