Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip file-level comment changes during editions codegen tests #1734

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

mkruskal-google
Copy link
Contributor

This was missed by some earlier changes, but follows the same pattern. During some upgrades from proto2/proto3, comments may get reformatted and result in unexpected codegen diffs from non-functional code

Copy link
Collaborator

@thomasvl thomasvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thomasvl thomasvl merged commit 7a3fbf4 into apple:main Nov 20, 2024
12 checks passed
@mkruskal-google mkruskal-google deleted the editions-codegen branch November 20, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants