Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

SFrame.read_json should accept a JSON string in addition to files #2564

Open
syoutsey opened this issue Nov 5, 2019 · 2 comments · May be fixed by #2756
Open

SFrame.read_json should accept a JSON string in addition to files #2564

syoutsey opened this issue Nov 5, 2019 · 2 comments · May be fixed by #2756
Assignees
@dhivyaaxim
Labels
engine enhancement

Comments

@syoutsey
Copy link
Collaborator

syoutsey commented Nov 5, 2019

There are use cases which require a JSON string to accepted to the SFrame.read_json initializer instead of a path to a file. This could happen when the SFrame needs to be built with the results of a web-request API, in which case avoiding writing to a file would be more performant.
@TobyRoseman
Copy link
Collaborator

This is a good feature request. It also looks like you could construct a pandas dataframe from a JSON string (via pandas.read_json). Then you could create a SFrame using the pandas dataframe (the SFrame constructor accepts a pandas dataframe as input).

@dhivyaaxim
Copy link
Contributor

@TobyRoseman Please assign this ticket to me as I would like to try fixing it and contribute .Thanks in advance!

@dhivyaaxim dhivyaaxim linked a pull request Nov 27, 2019 that will close this issue
Open
@TobyRoseman TobyRoseman added this to the 6.1 milestone Dec 10, 2019
@TobyRoseman TobyRoseman modified the milestones: 6.1, 6.2 Jan 30, 2020
@TobyRoseman TobyRoseman removed this from the 6.2 milestone Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dhivyaaxim dhivyaaxim

Labels
engine enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SFrame.read_json should accept a JSON string not just a path to JSON file. dhivyaaxim/turicreate
3 participants
@syoutsey @TobyRoseman @dhivyaaxim