Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slides structure #35

Open
jarvisc1 opened this issue Nov 22, 2024 · 5 comments
Open

Slides structure #35

jarvisc1 opened this issue Nov 22, 2024 · 5 comments
Assignees

Comments

@jarvisc1
Copy link
Contributor

We should attempt to have a consistent structure between the slides in these folders and how the slides are placed for devlopment.

At the moment the filepaths within a course being developed will be different for the ones in here. Plus the names of the slide folders are inconsistent.

I'd propose

A slides folder in each course which is identical to this slides repo.

For shiny it would go

shiny_course/slides/shiny/
Then inside this folder there would be
images
shiny01/ - images just for this slide and image
shiny02/ - images just for this slide and the slides files.

Then we just need to look at it a bit more to try and get the filepaths to not be changed when copying over.
Probably it's just having /images.

@aspina7
Copy link
Contributor

aspina7 commented Nov 22, 2024

unless ive understood you wrong .... i think we just want one images folder.
I think if its the same folder structure, we should just be able to cut/paste and we shouldnt have filepath issues....

@jarvisc1
Copy link
Contributor Author

So actually I think we what an image folder per slide folder for images in a single slide deck.

Then another global image folder for stuff that's used crossed them.

This code won't ever change though.

I've figured it out as I've done it and I can implement pretty easily.

@aspina7
Copy link
Contributor

aspina7 commented Nov 23, 2024

mmmm still reckon single images folder means less complication and less duplication

@jarvisc1
Copy link
Contributor Author

If the images in one slide deck overlap with the others a bunch then yeah. But the majority of slide images are in a single slide deck. So then if we have one images folder it's not easy to see which image relates to each slide.

Plus if we want to delete an image we have to search to see all the slide decks that they're in.

@aspina7
Copy link
Contributor

aspina7 commented Nov 23, 2024

very well - separate folders it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants