Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression after renaming *algorithm variables #75

Closed
Toreno96 opened this issue Dec 22, 2023 · 0 comments · Fixed by #76
Closed

Regression after renaming *algorithm variables #75

Toreno96 opened this issue Dec 22, 2023 · 0 comments · Fixed by #76
Assignees
@Toreno96
Labels
bug Something isn't working

Comments

@Toreno96
Copy link
Collaborator

After #68, if URI contains the algorithm optional parameter, e.g.

otpauth://totp/ACME%20Co:[email protected]?secret=HXDMVJECJJWSRB3HWIZR4IFUGFTMXBOZ&issuer=ACME%20Co&algorithm=SHA1&digits=6&period=30

the application will raise an error:

[2023-12-21 09:42:02,769] DEBUG:otp:352: 1 validation error for Uri
schema_ -> TOTPUriSchema -> parameters -> algorithm
  extra fields not permitted (type=value_error.extra)

I went too far with renaming all the variables, without enough testing.
@Toreno96 Toreno96 added the bug Something isn't working label Dec 22, 2023
@Toreno96 Toreno96 self-assigned this Dec 22, 2023
Toreno96 added a commit that referenced this issue Dec 22, 2023
@Toreno96
Fix regression after renaming *algorithm variables
c3f79c5 
Fixes #75.

* * *

After 6592be2
(#68) , if URI contains
the `algorithm` optional parameter, e.g.

```
otpauth://totp/ACME%20Co:[email protected]?secret=HXDMVJECJJWSRB3HWIZR4IFUGFTMXBOZ&issuer=ACME%20Co&algorithm=SHA1&digits=6&period=30
```

the application will raise an error:

```
[2023-12-21 09:42:02,769] DEBUG:otp:352: 1 validation error for Uri
schema_ -> TOTPUriSchema -> parameters -> algorithm
  extra fields not permitted (type=value_error.extra)
```
@Toreno96 Toreno96 mentioned this issue Dec 22, 2023
Merged
Toreno96 added a commit that referenced this issue Dec 22, 2023
@Toreno96
Fix regression after renaming *algorithm variables
961df32 
Fixes #75 (PR #76).

* * *

After 6592be2
(#68) , if URI contains
the `algorithm` optional parameter, e.g.

```
otpauth://totp/ACME%20Co:[email protected]?secret=HXDMVJECJJWSRB3HWIZR4IFUGFTMXBOZ&issuer=ACME%20Co&algorithm=SHA1&digits=6&period=30
```

the application will raise an error:

```
[2023-12-21 09:42:02,769] DEBUG:otp:352: 1 validation error for Uri
schema_ -> TOTPUriSchema -> parameters -> algorithm
  extra fields not permitted (type=value_error.extra)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Toreno96 Toreno96

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regression after renaming *algorithm variables apptension/onetimepass
1 participant
@Toreno96