Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kubelet-env config to make kubelet loglevel configurable #4

Closed
wants to merge 1 commit into from
Closed

Add kubelet-env config to make kubelet loglevel configurable #4

wants to merge 1 commit into from

Conversation

54nd20
Copy link
Member

@54nd20 54nd20 commented Dec 16, 2020 •
edited
Loading

Added ability to configure kubelet loglevel and set the default to loglevel 2
Closes #3

Checklist

  • Keep pull requests small so they can be easily reviewed.
  • Update the documentation.
  • Update the ./CHANGELOG.md.
  • Link this PR to related issues.

@54nd20 54nd20 requested a review from corvus-ch December 16, 2020 09:28
corvus-ch
corvus-ch suggested changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@corvus-ch corvus-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The knowledge base article contains two solutions (<4.6 and ≥4.6). At the moment, we have both versions running. In its current form, the change would brake things.

@54nd20 54nd20 marked this pull request as draft December 24, 2020 14:22
@DebakelOrakel
Copy link
Contributor

Is this still an issue, as 4.5 is quiet outdated?

@54nd20
Copy link
Member Author

54nd20 commented Mar 4, 2022

This pull request would only work for cluster versions <4.6, so it is not relevant anymore.

@54nd20 54nd20 closed this Mar 4, 2022
@54nd20 54nd20 deleted the kubelet-loglevel branch March 4, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corvus-ch corvus-ch corvus-ch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to control the log chattiness of the Kubelet
3 participants
@54nd20 @DebakelOrakel @corvus-ch