Seiso should be able to cleanup generic resources

[ccremer]

There's currently the seiso configmaps and seiso secrets feature.
The recent restructuring however looks very similar for both resource types: They watch the .metadata.creationTimestamp and .metadata.labels to decide whether to clean up objects. The internal logic is often reused for both resources.

However, those metadata is available to pretty much every object. I'd propose to use the dynamic client so that we can cleanup any kind of resources, even custom CRDs:

seiso cleanup secrets --older-than 1w --selector key=value
seiso cleanup pods --selector app=foo
seiso cleanup apps/v1/deployment --selector app=bar
seiso cleanup certmanager.k8s.io/v1alpha1/order --selector app.kubernetes.io/name=operator

Image tags need somewhat more sophisticated logic (and for generic registries they don't have the same metatdata), there I would keep the current feature.

[bittner]

This is a fantastic idea!

With respect to the command's name, I'd suggest to use something else though, as "seiso" already has the meaning of "cleanup". Maybe seiso generic is just good enough. It would say, "clean up a generic resource" (as opposed to a container image).

[ccremer]

I think the command usage is personal interpretation. Yes, Seiso means "cleanup" already so the second argument becomes redundant, but it could also be just regarded as the project name or binary name, and then the command usage feels more "english" and imperative when reading seiso, (please) cleanup secrets --older-than 1w.

But I have no hard feelings here, I'm fine with either.