Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestProcessor causes fatal errors for users on subnets due to issues with IpUtils::checkIp6 #5

Open
sydseter opened this issue Feb 5, 2016 · 1 comment
Labels

Comments

@sydseter
Copy link

sydseter commented Feb 5, 2016

Some users have reported Fatal error message when trying to downloading css files from internal networks. This leads to the site being rendered without css which leads to issues for customers. Our reverse proxy caches these responses which aggravate the issue.

The issue happens in the pre 2.8.2 release of http-foundation's IpUtils::checkIp6 the 3.0.2 possibly fixes the issue: https://github.com/symfony/http-foundation/commits/652e8af9d22c16c5b6556048136021db0b8c6640/IpUtils.php

We should consider upgrading to 3.0.2 and possibly also add a try catch around:

$record['extra']['clientIp'] = $this->getClientIp($this->app['request_stack']);

@sydseter sydseter added the bug label Feb 5, 2016
@gunnarlium
Copy link
Member

symfony/http-foundation requires php >=5.5.9, so until we migrate to a new platform, that's off the table.

I think the try/catch approach is preferable. Not getting the client ip in the logs for a few requests is not that big a deal, as long as we keep a ticket open for upgrading once our platform is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants