Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support clang-format #29485

Open
EkeMinusYou opened this issue Dec 3, 2024 · 6 comments
Open

Support clang-format #29485

EkeMinusYou opened this issue Dec 3, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@EkeMinusYou
Copy link
Contributor

Please support clang-format.

@suzuki-shunsuke suzuki-shunsuke added the enhancement New feature or request label Dec 3, 2024
@suzuki-shunsuke
Copy link
Member

suzuki-shunsuke commented Dec 3, 2024

How can we install this?
Are there pre-built binaries?
aqua can't build tools from source code when installing them except for some commands such as go build, go install, cargo install.

@EkeMinusYou
Copy link
Contributor Author

EkeMinusYou commented Dec 4, 2024

Thank you for reply!

As I see it, the binary is included in the GitHub Release. However, it seems that the binaries are not directly under GitHub Release, but in the bin directory such as LLVM-19.1.5-macOS-X64.tar.xz.

image

However, since the file is very large, I think it is better to build it.

@suzuki-shunsuke
Copy link
Member

Thank you.

Oh, so large.

LLVM-19.1.5-Linux-X64.tar.xz 1.54 GB
LLVM-19.1.5-macOS-X64.tar.xz 1.47 GB

I think it is better to build it.

aqua doesn't support building this from source code.

@suzuki-shunsuke
Copy link
Member

This tool includes many binaries in bin directory.
I'm wondering if we need to make all of them available.

$ ls -1 LLVM-19.1.5-macOS-X64/bin
amdgpu-arch
analyze-build
bbc
bugpoint
c-index-test
clang
clang++
clang-19
clang-apply-replacements
clang-change-namespace
clang-check
clang-cl
clang-cpp
clang-doc
clang-extdef-mapping
clang-format
clang-include-cleaner
clang-include-fixer
clang-installapi
clang-linker-wrapper
clang-move
clang-nvlink-wrapper
clang-offload-bundler
clang-offload-packager
clang-pseudo
clang-query
clang-refactor
clang-rename
clang-reorder-fields
clang-repl
clang-scan-deps
clang-tblgen
clang-tidy
clangd
clangd-xpc-test-client
darwin-debug
debugserver
diagtool
dsymutil
f18-parse-demo
find-all-symbols
fir-opt
flang-new
git-clang-format
hmaptool
intercept-build
ld.lld
ld64.lld
llc
lld
lld-link
lldb
lldb-argdumper
lldb-dap
lldb-instr
lldb-server
lli
llvm-addr2line
llvm-ar
llvm-as
llvm-bcanalyzer
llvm-bitcode-strip
llvm-bolt
llvm-bolt-heatmap
llvm-boltdiff
llvm-c-test
llvm-cat
llvm-cfi-verify
llvm-config
llvm-cov
llvm-cvtres
llvm-cxxdump
llvm-cxxfilt
llvm-cxxmap
llvm-debuginfo-analyzer
llvm-debuginfod
llvm-debuginfod-find
llvm-diff
llvm-dis
llvm-dlltool
llvm-dwarfdump
llvm-dwarfutil
llvm-dwp
llvm-exegesis
llvm-extract
llvm-gsymutil
llvm-ifs
llvm-install-name-tool
llvm-jitlink
llvm-lib
llvm-libtool-darwin
llvm-link
llvm-lipo
llvm-lto
llvm-lto2
llvm-mc
llvm-mca
llvm-ml
llvm-modextract
llvm-mt
llvm-nm
llvm-objcopy
llvm-objdump
llvm-opt-report
llvm-otool
llvm-pdbutil
llvm-profdata
llvm-profgen
llvm-ranlib
llvm-rc
llvm-readelf
llvm-readobj
llvm-readtapi
llvm-reduce
llvm-remarkutil
llvm-rtdyld
llvm-sim
llvm-size
llvm-split
llvm-stress
llvm-strings
llvm-strip
llvm-symbolizer
llvm-tblgen
llvm-tli-checker
llvm-undname
llvm-windres
llvm-xray
merge-fdata
mlir-cat
mlir-cpu-runner
mlir-linalg-ods-yaml-gen
mlir-lsp-server
mlir-minimal-opt
mlir-minimal-opt-canonicalize
mlir-opt
mlir-pdll
mlir-pdll-lsp-server
mlir-query
mlir-reduce
mlir-tblgen
mlir-transform-opt
mlir-translate
modularize
nvptx-arch
opt
perf2bolt
pp-trace
reduce-chunk-list
run-clang-tidy
sancov
sanstats
scan-build
scan-build-py
scan-view
set-xcode-analyzer
tblgen-lsp-server
tblgen-to-irdl
tco
verify-uselistorder
wasm-ld

@EkeMinusYou
Copy link
Contributor Author

It seems that, based on Homebrew, it might be possible to build only the target. However, since Aqua does not support building at the moment, I understand that it is currently difficult.

https://github.com/Homebrew/homebrew-core/blob/master/Formula/c/clang-format.rb

system "cmake", "--build", "build", "--target", "clang-format"

@suzuki-shunsuke
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants