aqua v2.42.0 replaces symbolic links with linked files when unarchiving assets

[suzuki-shunsuke]

aqua info

$ aqua info
{
  "version": "2.42.0",
  "commit_hash": "eec4e1a325fd7f0d7a618079227e374a34ccd0ed",
  "os": "darwin",
  "arch": "arm64",
  "pwd": "/Users/(USER)/Documents/aqua/aqua",
  "root_dir": "/Users/(USER)/.local/share/aquaproj-aqua",
  "env": {
    "AQUA_GLOBAL_CONFIG": ":/Users/(USER)/repos/src/github.com/aquaproj/aqua-registry/aqua-all.yaml",
    "AQUA_PROGRESS_BAR": "true"
  },
  "config_files": [
    {
      "path": "/Users/(USER)/Documents/aqua/aqua/aqua/aqua.yaml"
    }
  ]
}

Overview

At v2.42.0, we replaced mholt/archiver/v3 with mholt/archives.
Then we need to change the code to unarchive files.

aqua v2.42.0 replaces symbolic links in assets with linked files when unarchiving assets, which can break packages.

How to reproduce

aqua.yaml

---
registries:
  - type: standard
    ref: v4.292.0 # renovate: depName=aquaproj/aqua-registry
packages:
  - name: nodejs/[email protected]

Executed command and output

aqua rm node
aqua exec -- npm -v

Expected behaviour

npm succeeds.

Actual behaviour

npm fails.

$ aqua exec -- npm -v
INFO[0000] download and unarchive the package            aqua_version=2.42.0 env=darwin/arm64 exe_name=npm package_name=nodejs/node package_version=v23.5.0 program=aqua registry=standard
Downloading nodejs/node v23.5.0 100% |███████████████████████████████████████████████████████████████████████████| (49/49 MB, 49 MB/s)        
FATA[0002] aqua failed                                   aqua_version=2.42.0 env=darwin/arm64 error="it failed to start the process" exe_name=npm package_name=nodejs/node package_version=v23.5.0 program=aqua

Note

aqua v2.41.0:

$ ls -lh "$(dirname "$(aqua which npm)")"
total 121M
lrwxr-xr-x 1 shunsukesuzuki staff   45  1  6 23:18 corepack -> ../lib/node_modules/corepack/dist/corepack.js
-rwxr-xr-x 1 shunsukesuzuki staff 121M  1  6 23:18 node
lrwxr-xr-x 1 shunsukesuzuki staff   38  1  6 23:18 npm -> ../lib/node_modules/npm/bin/npm-cli.js
lrwxr-xr-x 1 shunsukesuzuki staff   38  1  6 23:18 npx -> ../lib/node_modules/npm/bin/npx-cli.js

aqua v2.42.0:

$ ls -lh "$(dirname "$(aqua which npm)")"
total 121M
-rwxr-xr-x 1 shunsukesuzuki staff    0  1  6 23:15 corepack
-rwxr-xr-x 1 shunsukesuzuki staff 121M  1  6 23:15 node
-rwxr-xr-x 1 shunsukesuzuki staff    0  1  6 23:15 npm
-rwxr-xr-x 1 shunsukesuzuki staff    0  1  6 23:15 npx

[suzuki-shunsuke]

• fix: create symlinks if unarchived files are symlinks #3433