From a90b14709f51067347d812a06914345613293b1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=9Fingen?= Date: Sat, 19 May 2018 13:57:01 +0200 Subject: [PATCH 1/2] Handle missing versions Show an error if any version is not found in `apm versions`. --- src/commands/apm_cmds/versions.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/commands/apm_cmds/versions.js b/src/commands/apm_cmds/versions.js index bd381ebfa..065b415cc 100644 --- a/src/commands/apm_cmds/versions.js +++ b/src/commands/apm_cmds/versions.js @@ -14,7 +14,11 @@ exports.handler = async function ({ reporter, module, bump, cwd, network, apm: a const versions = await APM(web3, apmOptions).getAllVersions(module.appName) reporter.info(`${module.appName} has ${versions.length} published versions`) versions.map((version) => { - reporter.success(`${version.version}: ${version.contractAddress} ${version.content.provider}:${version.content.location}`) + if (version === undefined) { + reporter.error('Version not found in provider') + } else { + reporter.success(`${version.version}: ${version.contractAddress} ${version.content.provider}:${version.content.location}`) + } }) process.exit() } From 258c71787563ea58cb2c98a48fd8a3e5d7ba5110 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=9Fingen?= Date: Tue, 22 May 2018 17:40:20 +0200 Subject: [PATCH 2/2] Handle missing versions Address PR#95 comments. --- src/commands/apm_cmds/versions.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/commands/apm_cmds/versions.js b/src/commands/apm_cmds/versions.js index 065b415cc..c47670c5c 100644 --- a/src/commands/apm_cmds/versions.js +++ b/src/commands/apm_cmds/versions.js @@ -14,10 +14,10 @@ exports.handler = async function ({ reporter, module, bump, cwd, network, apm: a const versions = await APM(web3, apmOptions).getAllVersions(module.appName) reporter.info(`${module.appName} has ${versions.length} published versions`) versions.map((version) => { - if (version === undefined) { - reporter.error('Version not found in provider') - } else { + if (version && version.content) { reporter.success(`${version.version}: ${version.contractAddress} ${version.content.provider}:${version.content.location}`) + } else { + reporter.error('Version not found in provider') } }) process.exit()