Buidler migration #59
Conversation
There was a problem hiding this comment.
Thanks for doing this @sembrestels! I had a few questions to ask about before merging :)
| @@ -7,20 +7,23 @@ node_modules | |||
| */**/coverage.json | |||
| */**/allFiredEvents | |||
| */**/scTopics | |||
|
|
|||
| */**/.coverage_* | |||
There was a problem hiding this comment.
Hmm, is this from the new solidity-coverage version? Can we remove some of the previous lines on ignoring the previous version's coverage output?
| @@ -1,21 +1,31 @@ | |||
|
|
|||
There was a problem hiding this comment.
Let's remove this extra newline :)
| { | ||
| "presets": [ | ||
| [ | ||
| "@babel/preset-env", | ||
| { | ||
| "modules": false, | ||
| "targets": { |
There was a problem hiding this comment.
I forget exactly, but is the browserlist in the package.json enough or do we need to specify targets here as well for @babel/present-env?
| const { usePlugin } = require('@nomiclabs/buidler/config') | ||
| const hooks = require('./scripts/buidler-hooks') | ||
|
|
||
| usePlugin('@aragon/buidler-aragon') |
There was a problem hiding this comment.
Since this plugin is not really in active development anymore, what do you think about removing any configuration or dependencies that rely on it? Or was this still essential to your workflow?
This PR includes the following changes:
.babelrcfile@aragon/contract-test-helpersto@aragon/contract-helpers-testMANAGE_POWER_SOURCE_ROLEid in arapp.json fileCloses #56.