Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Oracle DB as vector store #995

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Oracle DB as vector store #995

wants to merge 2 commits into from

Conversation

IlyasOsman
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature
  • Why was this change needed? (You can also link to an open issue here)
    closes Using Oracle Vector store #981

@vercel Vercel
Copy link

vercel bot commented Jun 12, 2024

@IlyasOsman is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the application Application label Jun 12, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 10:28am

@siiddhantt
Copy link
Collaborator

Hi @IlyasOsman , I'm getting an error :
TypeError: OracleDBVectorStore.__init__() got an unexpected keyword argument 'path'
whenever trying to upload any doc. This is because the path field hasn't been accounted for in your class.

@dartpain
Copy link
Contributor

dartpain commented Oct 5, 2024

just a few comments:

  1. please filter on source_id during search (you can get it on init) check out other vectorstores
  2. Lets lazy load our dependency

Thank you, very sorry for delays.
Also where is best to test this db?

@dartpain
Copy link
Contributor

dartpain commented Oct 5, 2024 •
edited
Loading

Yeah that path comment is now source_id @IlyasOsman similar to 'path' @siiddhantt mentioned above

@dartpain dartpain mentioned this pull request Oct 5, 2024
Open
@dartpain
Copy link
Contributor

Hey @IlyasOsman is there any update?
thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
application Application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using Oracle Vector store
3 participants
@IlyasOsman @siiddhantt @dartpain