Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button shows up underneath Youtube video [Fix included!] #20

Open
jpadvo opened this issue Oct 5, 2010 · 0 comments
Open

Close button shows up underneath Youtube video [Fix included!] #20

jpadvo opened this issue Oct 5, 2010 · 0 comments

Comments

@jpadvo
Copy link

jpadvo commented Oct 5, 2010

[I'm a noob. I learned about the ability to request a pull, so I did that with this code. Cheers! ]

When embedding a youtube video, the corner of the flash player cuts off the close button. This kind of problem is often fixed by setting the wmode of the embed to 'transparent,' but this can hurt the framerate of the video. It solves the problem and doesn't hurt the framerate to set the wmode to 'opaque.' If this is done in four places it solves the problem:

Starting at line 622:

object.append(jQuery("<embed></embed>").attr({
                                              src            : options.reference,
                                              width          : options.width,
                                              height         : options.height,
                                              wmode          : "opaque",     /* <-- RIGHT HERE */
                                              allowfullscreen: "true",
                                              type           : "application/x-shockwave-flash",
                                              pluginspage    : "http://get.adobe.com/flashplayer/"}));

Starting at line 645:

 object.append(jQuery("<embed></embed>").attr({
                                              src            : TopUp.host + TopUp.players_path + "flvplayer.swf", 
                                              width          : options.width,
                                              height         : options.height,
                                              wmode          : "opaque",      /* <-- RIGHT HERE */
                                              flashvars      : "file=" + options.reference + "&autostart=true",
                                              allowfullscreen: "true",
                                              type           : "application/x-shockwave-flash",
                                              pluginspage    : "http://get.adobe.com/flashplayer/"}));

Starting at line 671:

object.append(jQuery("<embed></embed>").attr({
                                              src        : options.reference,
                                              width      : options.width,
                                              height     : options.height,
                                              wmode      : "opaque",     /* <-- RIGHT HERE */
                                              scale      : "aspect", 
                                              bgcolor    : "black",
                                              showlogo   : "false", 
                                              autoplay   : "true",
                                              type       : "video/quicktime",
                                              pluginspage: "http://www.apple.com/quicktime/download/"}));

Starting at line 697:

object.append(jQuery("<embed></embed>").attr({
                                              src        : options.reference,
                                              width      : options.width,
                                              height     : options.height,
                                              wmode      : "opaque",     /* <-- RIGHT HERE */
                                              controls   : "imagewindow",
                                              console    : "one",
                                              autostart  : "true",
                                              nojava     : "true",
                                              type       : "audio/x-pn-realaudio-plugin",
                                              pluginspage: "http://www.real.com/freeplayer/?rppr=rnwk"}));
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant