Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JQuery 1.4.4 compatibility #22

Open
rainerfrey opened this issue Nov 19, 2010 · 2 comments
Open

JQuery 1.4.4 compatibility #22

rainerfrey opened this issue Nov 19, 2010 · 2 comments

Comments

@rainerfrey
Copy link

With JQuery 1.4.4 I have the problem that the image lightbox opens in a minimal sized window (just showing the prev/next controls). On a click the correct size shows. On navigation in the group the location of the lightbox window moves down on the page (with every click on prev/next). These issues don't exist with JQuery 1.4.2.

I have this issue in a rails application that is quite unfinished, so it is difficult to show. If necessery, I'll try to provide a sample page that show the issue. Comments on gettopup.com report the same problem, so it should be easy to reproduce. Here are excerpts of the page:

<script src="/javascripts/jquery.js?1289927079" type="text/javascript"></script> 
<script src="/javascripts/jquery-ui.js?1288714555" type="text/javascript"></script> 
<script src="/javascripts/rails.js?1290186918" type="text/javascript"></script> 
<script src="/javascripts/top_up.js?1267987680" type="text/javascript"></script> 
<script src="/javascripts/application.js?1290180668" type="text/javascript"></script> 

<div class="photo" id="photo_6"> 
<a href="/system/photos/6/view/20100110_img_0196.JPG" class="photo"> 
    <img alt="20100110_img_0196" src="/system/photos/6/page/20100110_img_0196.JPG?1289416940" /> 
    </a>    <a href="/photos/6" data-confirm="Are you sure?" data-method="delete" rel="nofollow">[x]</a> 
</div>

From application.js:

TopUp.images_path="/images/top_up/";
TopUp.addPresets(
{
    "a.photo": {
        type: "image",
        group: "images",
        layout: "quicklook",
        modal: 0
    }
}
);
@elvetemedve
Copy link

Acutually it does not work with jquery 1.4.3 or later, neither 1.5.

@timc3
Copy link

timc3 commented Jun 11, 2011

Comment out the following:
if (to == "top_up") { jQuery("#top_up .te_content").css({width: jQuery("#temp_up .te_content").css("width"), height: jQuery("#temp_up .te_content").css("height")}); }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants