Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(proto): use buf 1.31 to push files #572

Merged
merged 7 commits into from
May 23, 2024

Conversation

aelesbao
Copy link
Member

@aelesbao aelesbao commented May 21, 2024

The buf CLI v1.32 seems to have an undocumented breaking change and won't accept the buf.yaml file structure defined on v1.

This is possibly a bug on their side since it's mentioned in the changelog that the CLI is backwards compatible with v1 projects.

@aelesbao aelesbao requested a review from a team as a code owner May 21, 2024 12:36
@aelesbao aelesbao requested a review from philabsbot May 21, 2024 12:36
@aelesbao aelesbao changed the title fix(proto): install buf v1.32 to push proto files ci(proto): use buf 1.31 to push files May 21, 2024
@aelesbao aelesbao requested a review from a team as a code owner May 21, 2024 17:35
@aelesbao aelesbao requested a review from spoo-bar May 21, 2024 17:35
@aelesbao aelesbao requested review from zanicar and removed request for philabsbot May 21, 2024 17:40
Copy link
Contributor

@zanicar zanicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aelesbao aelesbao merged commit c5dcaa3 into main May 23, 2024
8 of 9 checks passed
@aelesbao aelesbao deleted the sol-280-automatically-publish-the-proto-files branch May 23, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants