Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View components (re)organization #563

Open
Danziger opened this issue Dec 4, 2024 · 0 comments
Open

View components (re)organization #563

Danziger opened this issue Dec 4, 2024 · 0 comments
Labels

Comments

@Danziger
Copy link
Contributor

Danziger commented Dec 4, 2024

Most "view" components have been renamed to <ComponentName>View and updated to use named exports in:

However, most file names still do not reflect those are "views" rather than regular components. Also, while some inline components have been extracted from the "view" files into their own, some are still defined there, specially all styled components.

This task includes:

  • Rename all files that export a component named <ComponentName>View to component-name.view.tsx.
  • Place them in their own folder: src/.../component-name/component-name.view.tsx.
  • Extract all styled components to their own file next to the view file: src/.../component-name/component-name.styles.tsx.
  • If additional components other than the view component itself are also defined in the view component's file, move it into the ~components directory.
  • If needed, you can also create src/.../component-name/component-name.utils.tsx and src/.../component-name/component-name.constants.tsx to "clean up" the .view.tsx file.

Suggestion:

Create one PR to do this in views for the Welcome and Dashboard apps first, a second one for the Auth app and the last one for the main Popup app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant