Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing: Welcome pages do (some) routing manually #567

Open
Danziger opened this issue Dec 4, 2024 · 0 comments
Open

Routing: Welcome pages do (some) routing manually #567

Danziger opened this issue Dec 4, 2024 · 0 comments
Assignees
Labels

Comments

@Danziger
Copy link
Contributor

Danziger commented Dec 4, 2024

Welcome pages still do routing manually (with conditionals). Instances of this are marked with the following comment: // TODO: Use a nested router instead:

Additionally, navigate() (from useLocation()) can be called with 2 special values on pages where their URL ends in "/" + number, navigate("prev") and navigate("next"), instead of manually calculating the next and previous pages.

This change should also allow the removal all usages of wouter's useRoute() in Welcome views. The params should instead come from the view props (props.params). That requires some views to be refactored to use the router <Routes>.

@Danziger Danziger added the good first issue Good for newcomers label Dec 4, 2024
@Danziger Danziger changed the title Auth: Welcome pages do (some) routing manually Routing: Welcome pages do (some) routing manually Dec 4, 2024
@Jonathansoufer Jonathansoufer self-assigned this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants