Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for React-Native-Windows by setting keyboard event height (Patch included) #74

Open
creambyemute opened this issue Jun 18, 2021 · 0 comments

Comments

@creambyemute
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on to patch KeyboardAccessoryView to support RN-Windows.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-keyboard-accessory/KeyboardAccessoryView.js b/node_modules/react-native-keyboard-accessory/KeyboardAccessoryView.js
index 920ed39..0b2aa3e 100644
--- a/node_modules/react-native-keyboard-accessory/KeyboardAccessoryView.js
+++ b/node_modules/react-native-keyboard-accessory/KeyboardAccessoryView.js
@@ -84,7 +84,8 @@ class KeyboardAccessoryView extends Component {
       ios: keyboardEvent.endCoordinates.height,
       android: this.props.androidAdjustResize
         ? 0
-        : keyboardEvent.endCoordinates.height
+        : keyboardEvent.endCoordinates.height,
+      windows: keyboardEvent.endCoordinates.height
     });
 
     const keyboardAnimate = () => {

This issue body was partially generated by patch-package.

@creambyemute creambyemute changed the title Add Support for React-Native-Windows by setting keyboard event height Add Support for React-Native-Windows by setting keyboard event height (Patch included) Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant