Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic for canRunOnBattery() is inverted #38

Open
htrinkle opened this issue Dec 6, 2023 · 0 comments
Open

Logic for canRunOnBattery() is inverted #38

htrinkle opened this issue Dec 6, 2023 · 0 comments
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@htrinkle
Copy link

htrinkle commented Dec 6, 2023 •
edited by per1234
Loading

Arduino_BQ24195/src/BQ24195.cpp

Line 1080 in 78dc698

if(DATA & 0x01) {

Bit 1 of status register (VSYS_STAT) is set if VSYSMIN regulation is active. Therefore "canRunOnBattery" if VSYS_MIN bit is NOT set.
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@per1234 @htrinkle