Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download url parser discards port #28

Closed
f0x52 opened this issue Dec 17, 2023 · 0 comments · Fixed by #34
Closed

Download url parser discards port #28

f0x52 opened this issue Dec 17, 2023 · 0 comments · Fixed by #34
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@f0x52
Copy link

f0x52 commented Dec 17, 2023

After being quite confused why the OTA library could not connect to my storage server, I realized from this code that the port I specified (8080) wasn't being used at all.

https://github.com/arduino-libraries/Arduino_ESP32_OTA/blob/main/src/Arduino_ESP32_OTA.cpp#L119 always sets port to 80 for http and 443 for https, and the URI parser seems to not handle : at all (https://github.com/arduino-libraries/Arduino_ESP32_OTA/blob/main/src/decompress/utility.cpp#L88).

That last function is quite confusing, so no easy fix PR from my side, alas.
@pennam pennam mentioned this issue May 22, 2024
Merged
@per1234 per1234 linked a pull request May 22, 2024 that will close this issue
Non blocking download #34
Merged
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself conclusion: resolved Issue was resolved labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Non blocking download arduino-libraries/Arduino_ESP32_OTA
2 participants
@per1234 @f0x52