Issue #6 fixed and reading functions added #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue # 6 was that createchar() function leave data address in CGRAM position. After that, begin(), setCursor(),clear() or home() functions must be executed before write() function in order for it to work. It is fixed but require rw pin to be set for it to work. This is because, when address register goes to CGRAM, there is no record of its previous position in our MCU. MCU must read its previous position in order for it to go back. In case rw pin is not specified, the register is not returned and it cannot untill rw is specified. Also Added following functions, read_BF_addr read_RAM read read4bits read8bits
zaidMughal
changed the title
per1234
requested changes
Mar 20, 2020
camelCase corrected in two functions.
read function return type changed to int so they give -1 if not read. Also readRAM generates an error if both inlined and used in cpp file. Either we put it in .h file or not make it a normal function. So I made it a normal function.
per1234
reviewed
Mar 21, 2020
per1234
previously requested changes
Mar 21, 2020
|
|
per1234
added
type: imperfection
|
@per1234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6 was that createchar() function leave data address in CGRAM position. After that, begin(), setCursor(),clear() or home() functions must be executed before write() function in order for it to work. It is fixed but require rw pin to be set for it to work. This is because, when address register goes to CGRAM, there is no record of its previous position in our MCU. MCU must read its previous position in order for it to go back. In case rw pin is not specified, the register is not returned and it cannot untill rw is specified.
Also Added following functions,
read_BF_addr
read_RAM
read
read4bits
read8bits