-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ABP hangup and add new getters #93
base: master
Are you sure you want to change the base?
Conversation
Memory usage change @ e14aa72
Click for full report table
Click for full report CSV
|
Optimized parser of waitResponse that peeks for terminator allowing chained commands to be parsed. Auto-detect compatibility mode <1.2.4 Includes firmware 1.2.4 with changes
Memory usage change @ fa55962
Click for full report table
Click for full report CSV
|
Memory usage change @ ca0bd8b
Click for full report table
Click for full report CSV
|
Memory usage change @ 7eae6c3
Click for full report table
Click for full report CSV
|
Finished tests, think I'm done here. Anything else? |
Memory usage change @ 430e02c
Click for full report table
Click for full report CSV
|
Memory usage change @ 05491ef
Click for full report table
Click for full report CSV
|
@sslupsky anyone reviewing this? would solve a lot of open issues 😃 |
Agree - looking forward to this being merged 👍 |
guys? |
Ping? |
This PR fixes a lot of issues with the current master (v1.2.3), but it unfortunately seems to have introduced another. I'm not able to send binary data, or at least send it correctly (it works on master). For example, sending a package with 3 bytes [0,1,255] (0x00, 0x01, 0xFF) returns -7 (LORA_ERROR_RX). I have tried using For my applications this is a big deal since I need to send as much data as possible as often as possible. |
@Larshand92 This could explain your data doubling at the network server. You have double the data because to tx binary we have to translate bytes to ascii, i.e., we take the hex value and translate it to two ascii chars, to send it over the serial terminal to the lora modem. The modem firmware has then to translate it back. It seems that in your case the firmware is not doing that. Can you follow up on this? |
Changed library version to match firmware v1.2.3, updated firmware with fixes to 1.2.3 from pull request 35
I've fixed a problem where the getJoinStatus function waited forever for a response as it parsed the wrong
+OK
response still in the buffer. Also a minor issue with the channel mask's char buffer.Added getters for Power, RSSI, and SNR.