Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controlledMotion example for servo library #40

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

mash197
Copy link

@mash197 mash197 commented Mar 12, 2020

This is an additional example for the servo library that works as follows : As Long as the button is pushed down the servo will move in a counter-clockwise direction in a stepsize of one degree till it reaches 180 degrees and then returns to start from the zero position automatically.

This is an additional example for the servo library that works as follows :  As Long as the button is pushed down the servo will move in a counter-clockwise direction in a stepsize of one degree till it reaches 180 degrees and then returns to start from the zero position automatically.
Attached above is a snapshot for the controlled motion circuit example which depicts the wiring used to run the example code in the cotrolledMotion.ino file
Added a description for the circuit in words apart from the graphical description represented by the attached image in this directory
examples/controlledMotion/controlledMotion.ino Outdated Show resolved Hide resolved
examples/controlledMotion/controlledMotion.ino Outdated Show resolved Hide resolved
examples/controlledMotion/controlledMotion.ino Outdated Show resolved Hide resolved
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The established convention for Arduino sketches is for the first letter of the file name/folder name to be capitalized: ControlledMotion/ControlledMotion.ino

mash197 and others added 8 commits March 14, 2020 12:59
Renamed the controlledMotion.ino file and its parent directory to follow the naming conventions to begin with a capital letter.
Repositioning this sketch in a separate sketches folder
Placing all the circuit sketches in this folder
Adding the circuit sketch after modifying its name to follow the naming conventions that is to start with a capital letter
@per1234 per1234 dismissed their stale review March 14, 2020 11:19

Requested changes have been made. Thanks!

@mash197 mash197 closed this Mar 14, 2020
@mash197 mash197 reopened this Mar 14, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@per1234 per1234 added type: enhancement Proposed improvement topic: documentation Related to documentation for the project labels Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants