From 32d46c03eda6dec26e8b1733ceaad5cb31a102bf Mon Sep 17 00:00:00 2001 From: Cristian Maglie Date: Mon, 9 Oct 2023 14:23:33 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Umberto Baldi <34278123+umbynos@users.noreply.github.com> --- docs/platform-specification.md | 3 +-- internal/cli/debug/debug.go | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/docs/platform-specification.md b/docs/platform-specification.md index 3dad47df61c..52fa4379942 100644 --- a/docs/platform-specification.md +++ b/docs/platform-specification.md @@ -1357,7 +1357,7 @@ directives: - `debug.server`: is a unique identifier of the required debug server, currently we support only `openocd` - `debug.svd_file`: is the absolute path to the SVD descriptor. -OpenOCD server specific confgiurations: +OpenOCD server specific configurations: - `debug.server.openocd.path`: is the absolute path to the OpenOCD directory - `debug.server.openocd.scripts_dir`: is the absolute path to the OpenOCD scripts directory @@ -1389,7 +1389,6 @@ will result in the following JSON to be merged in the Arduino IDE generated `lau ```json { - "anotherStringParamer": "hellooo", "overrideRestartCommands": ["monitor reset halt", "monitor gdb_sync", "thb setup", "c"], "postAttachCommands": [ "set remote hardware-watchpoint-limit 2", diff --git a/internal/cli/debug/debug.go b/internal/cli/debug/debug.go index a2e2f78bbae..69d9ddd716c 100644 --- a/internal/cli/debug/debug.go +++ b/internal/cli/debug/debug.go @@ -135,7 +135,7 @@ type openOcdServerConfigResult struct { } func newDebugInfoResult(info *rpc.GetDebugConfigResponse) *debugInfoResult { - var toolchaingConfig interface{} + var toolchainConfig interface{} var serverConfig interface{} switch info.Server { case "openocd": @@ -160,7 +160,7 @@ func newDebugInfoResult(info *rpc.GetDebugConfigResponse) *debugInfoResult { Toolchain: info.Toolchain, ToolchainPath: info.ToolchainPath, ToolchainPrefix: info.ToolchainPrefix, - ToolchainConfig: toolchaingConfig, + ToolchainConfig: toolchainConfig, Server: info.Server, ServerPath: info.ServerPath, ServerConfig: serverConfig,