Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests for strings #122

Open
aregtech opened this issue Feb 13, 2023 · 11 comments · May be fixed by #429
Open

Unit Tests for strings #122

aregtech opened this issue Feb 13, 2023 · 11 comments · May be fixed by #429
Labels
C++ enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed unit test

Comments

@aregtech
Copy link
Owner

Motivation.
The string functions are classes are essential, which are used in many cases. It is important to have unit test and very high code coverage of these objects and methods.

Actions

  • In the unit test folder create at least one file to implement unit tests;
  • Similar to DemoTest, include the test in the CMakeLists.txt so that it will compile separate executable.
  • All test methods of unit test should be documented with short description of the test agenda.

Additional actions
If a bug is found (test failed), there should be a ticket created and the UT code should be included to demonstrate failure.

@aregtech aregtech added enhancement New feature or request C++ unit test labels Feb 13, 2023
@aregtech
Copy link
Owner Author

@harshit496, here is the ticket. I don't know why, i cannot assign the ticket to you. Try to assign yourself. Or maybe you need to message here that I can assign this ticket to you.

@harshit496
Copy link
Contributor

No, even I am not able to self-assign this

@aregtech
Copy link
Owner Author

@harshit496 , i've managed

@harshit496
Copy link
Contributor

harshit496 commented Feb 14, 2023

@aregtech I am including the test in https://github.com/aregtech/areg-sdk/blob/master/tests/units/CMakeLists.txt but it still does seem to compile it. am I missing something?
PS: I am using GitHub codespaces

@aregtech
Copy link
Owner Author

@harshit496, where do you work? I can create a branch, merge your changes I'll have a look.

@aregtech
Copy link
Owner Author

@harshit496, the branch for you to merge and work. To checkout

git fetch origin
git checkout feature/122-unit-tests-for-strings

@harshit496
Copy link
Contributor

@aregtech i haven't created a branch yet. I will add my changes to this branch then

@harshit496
Copy link
Contributor

@aregtech ok nvm I've managed to get it working. Something was wrong with my codespaces setup. Thanks anyways

@aregtech
Copy link
Owner Author

@harshit496 , it seems you are very busy. At the moment I remove the ticket assignment in the case if someone else want to continue. I'll assign to you when have more time.
Anyway, thank you for contribution.

@aregtech aregtech added help wanted Extra attention is needed good first issue Good for newcomers labels Jul 19, 2023
@harshit496
Copy link
Contributor

@aregtech thank you for your patience and apologies for responding late, yes I was swamped with some personal stuff however I am now available to contribute and would love jump back on this issue.Thx.

@aregtech
Copy link
Owner Author

aregtech commented Sep 4, 2023

Hi @harshit496 , i hope you are fine.
No problem.
Just fyi, i was making some cleanups and occasionally deleted the branch where you committed your changes.

@harshit496 harshit496 linked a pull request Nov 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed unit test
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants