Skip to content

Commit

Permalink
fix: docs
Browse files Browse the repository at this point in the history
Signed-off-by: shuangkun <[email protected]>
  • Loading branch information
shuangkun committed Mar 19, 2024
1 parent 143bd5a commit 465c5ec
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
6 changes: 6 additions & 0 deletions docs/container-set-template.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,3 +116,9 @@ Example B: Lopsided requests, e.g. `a -> b` where `a` is cheap and `b` is expens
Can you see the problem here? `a` only has small requests, but the container set will use the total of all requests. So it's as if you're using all that GPU for 10h. This will be expensive.

Solution: do not use container set when you have lopsided requests.

## ContainerSetRetryStrategy

ContainerSetRetryStrategy describes how to retry a container nodes in the container set if it fails.
Nbr of retries(default 0) and sleep duration between retries(default 0s, instant retry) can be set.
The shell command should be normal otherwise it will not be retried.
1 change: 1 addition & 0 deletions pkg/apis/workflow/v1alpha1/container_set_template_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ type ContainerSetTemplate struct {
VolumeMounts []corev1.VolumeMount `json:"volumeMounts,omitempty" protobuf:"bytes,3,rep,name=volumeMounts"`
// RetryStrategy describes how to retry a container nodes in the container set if it fails.
// Nbr of retries(default 0) and sleep duration between retries(default 0s, instant retry) can be set.
// The shell command should be normal otherwise it will not be retried.
RetryStrategy *ContainerSetRetryStrategy `json:"retryStrategy,omitempty" protobuf:"bytes,5,opt,name=retryStrategy"`
}

Expand Down

0 comments on commit 465c5ec

Please sign in to comment.