Add tests for Facade.proxyFunc to ensure correct proxy function is …

…returned based on configuration

Signed-off-by: shimako55 <[email protected]>

pkg/apiclient/http1/facade.go

@@ -183,3 +183,10 @@ func parseHeaders(headerStrings []string) (http.Header, error) {
 	}
 	return headers, nil
 }
+
+func (h *Facade) proxyFunc() func(*http.Request) (*url.URL, error) {
+	if h.proxy != nil {
+		return h.proxy
+	}
+	return http.ProxyFromEnvironment
+}

pkg/apiclient/http1/facade_test.go

@@ -1,6 +1,9 @@
 package http1
 
 import (
+	"net/http"
+	"net/url"
+	"reflect"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -14,3 +17,34 @@ func TestFacade_do(t *testing.T) {
 		assert.Equal(t, "http://my-url/my-ns/?labels.foo=1", u.String())
 	}
 }
+
+func TestFacade_proxyFunc(t *testing.T) {
+	proxyFunc := func(_ *http.Request) (*url.URL, error) {
+		return nil, nil
+	}
+	tests := []struct {
+		name  string
+		proxy func(*http.Request) (*url.URL, error)
+		want  func(*http.Request) (*url.URL, error)
+	}{
+		{
+			name:  "use proxy settings from environment variables",
+			proxy: nil,
+			want:  http.ProxyFromEnvironment,
+		},
+		{
+			name:  "use specific proxy",
+			proxy: proxyFunc,
+			want:  proxyFunc,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			f := Facade{proxy: tt.want}
+			got := f.proxyFunc()
+			if reflect.ValueOf(got).Pointer() != reflect.ValueOf(tt.want).Pointer() {
+				t.Errorf("Facade.proxyURL() = %p, want %p", got, tt.want)
+			}
+		})
+	}
+}