feat(script): allow setting file extension

Signed-off-by: Andrzej Ressel <[email protected]>

docs/walk-through/scripts-and-results.md

@@ -1,6 +1,6 @@
 # Scripts And Results
 
-Often, you just want a template that executes a script specified as a here-script (also known as a `here document`) in the workflow spec. This example shows how to do that:
+You can use a `script` template to execute an inline script (also known as a ["here document"](https://en.wikipedia.org/wiki/Here_document)):
 
 ```yaml
 apiVersion: argoproj.io/v1alpha1
@@ -62,7 +62,7 @@ spec:
   - name: gen-random-scala
     script:
       image: virtuslab/scala-cli:1.5.0
-      command: [scala-cli] # the scala-cli requires file to end in either `.scala` or `.sc`
+      command: [scala-cli] # the scala-cli requires files to end in either `.scala` or `.sc`
       extension: sc # the file will now end in `.sc`
       source: |
         import scala.util.Random

examples/scripts-java.yml

@@ -26,8 +26,8 @@ spec:
   - name: gen-random-int
     script:
       image: eclipse-temurin:22.0.2_9-jdk
-      command: [java]
-      extension: java
+      command: [java] # the Java interpreter requires files to end in `.java`
+      extension: java # the file will now end in `.java`
       source: |
         import java.util.*;
 

examples/scripts-scala.yml

@@ -26,8 +26,8 @@ spec:
   - name: gen-random-int
     script:
       image: virtuslab/scala-cli:1.5.0
-      command: [scala-cli]
-      extension: sc
+      command: [scala-cli] # the scala-cli requires file to end in either `.scala` or `.sc`
+      extension: sc # the file will now end in `.sc`
       source: |
         import scala.util.Random
         println(Random.between(0, 100))

pkg/apis/workflow/v1alpha1/workflow_types.go

@@ -823,8 +823,7 @@ const (
 )
 
 func (tmpl *Template) GetScriptSourcePath() string {
-	extension := tmpl.Script.Extension
-	if len(extension) != 0 {
+	if tmpl.Script != nil && len(tmpl.Script.Extension) != 0 {
 		return executorScriptSourcePath + "." + tmpl.Script.Extension
 	} else {
 		return executorScriptSourcePath

test/e2e/functional/scripts-java.yml

@@ -0,0 +1 @@
+../../../examples/scripts-java.yml

test/e2e/functional/scripts-scala.yml

@@ -0,0 +1 @@
+../../../examples/scripts-scala.yml

workflow/controller/operator.go

@@ -3088,8 +3088,7 @@ func (woc *wfOperationCtx) executeScript(ctx context.Context, nodeName string, t
 	if len(tmpl.Script.Source) == 0 {
 		woc.log.Warn("'script.source' is empty, suggest change template into 'container'")
 	} else {
-		scriptSourcePath := tmpl.GetScriptSourcePath()
-		mainCtr.Args = append(mainCtr.Args, scriptSourcePath)
+		mainCtr.Args = append(mainCtr.Args, tmpl.GetScriptSourcePath())
 	}
 	_, err = woc.createWorkflowPod(ctx, nodeName, []apiv1.Container{mainCtr}, tmpl, &createWorkflowPodOpts{
 		includeScriptOutput: includeScriptOutput,