Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flakey test about lifecycle hooks (sub issue from #10807) #10897

Closed
3 tasks done
GeunSam2 opened this issue Apr 13, 2023 · 0 comments · Fixed by #10898
Closed
3 tasks done

Flakey test about lifecycle hooks (sub issue from #10807) #10897

GeunSam2 opened this issue Apr 13, 2023 · 0 comments · Fixed by #10898
Labels
area/build Build or GithubAction/CI issues area/hooks type/bug type/tech-debt

Comments

@GeunSam2
Copy link
Contributor

GeunSam2 commented Apr 13, 2023 •
edited
Loading

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issues exists when I tested with :latest
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

for #10807 (comment)

Version

latest

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

See recent CI builds

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
GeunSam2 added a commit to GeunSam2/argo-workflows that referenced this issue Apr 13, 2023
@GeunSam2
fix: add sleep for hooks test.argoproj#10897
b40e698 
Signed-off-by: GeunSam2 <[email protected]>
@GeunSam2 GeunSam2 changed the title Flaky test for lifecycle hooks (sub issue from #10807) Flaky test about lifecycle hooks (sub issue from #10807) Apr 13, 2023
@GeunSam2 GeunSam2 mentioned this issue Apr 13, 2023
Merged
terrytangyuan pushed a commit that referenced this issue Apr 13, 2023
@GeunSam2
fix: Flaky test about lifecycle hooks. Fixes #10897 (#10898)
12f4659 
Signed-off-by: GeunSam2 <[email protected]>
@terrytangyuan terrytangyuan mentioned this issue May 22, 2023
Closed
44 tasks
terrytangyuan pushed a commit that referenced this issue May 25, 2023
@GeunSam2 @terrytangyuan
fix: Flaky test about lifecycle hooks. Fixes #10897 (#10898)
7fc7b58 
Signed-off-by: GeunSam2 <[email protected]>
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this issue Jul 4, 2023
@GeunSam2 @JPZ13
fix: Flaky test about lifecycle hooks. Fixes argoproj#10897 (argoproj…
ce26d4d 
…#10898)

Signed-off-by: GeunSam2 <[email protected]>
@agilgur5 agilgur5 added type/tech-debt area/build Build or GithubAction/CI issues area/hooks labels Mar 24, 2024
@agilgur5 agilgur5 changed the title Flaky test about lifecycle hooks (sub issue from #10807) Flakey test about lifecycle hooks (sub issue from #10807) Mar 24, 2024
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this issue May 9, 2024
@GeunSam2 @dpadhiar
fix: Flaky test about lifecycle hooks. Fixes argoproj#10897 (argoproj…
2e2d545 
…#10898)

Signed-off-by: GeunSam2 <[email protected]>
Signed-off-by: Dillen Padhiar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build Build or GithubAction/CI issues area/hooks type/bug type/tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Flakey test about lifecycle hooks. Fixes #10897 GeunSam2/argo-workflows
2 participants
@agilgur5 @GeunSam2