Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make argoexec-image returns error in Windows expected 'package', found signal_darwin #12603

Closed
4 tasks done
tczhao opened this issue Feb 1, 2024 · 2 comments
Closed
4 tasks done
Labels
area/build Build or GithubAction/CI issues area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix area/executor area/windows Windows Container support P3 Low priority solution/duplicate This issue or PR is a duplicate of an existing one solution/workaround There's a workaround, might not be great, but exists type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@tczhao
Copy link
Member

tczhao commented Feb 1, 2024

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issue exists when I tested with :latest
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

make start make argoexec image used to work in windows with windows file system and devcontainer prior to 3.4.x

Now it returns

$ make dist/argoexec 
GIT_COMMIT=877c5523066e17687856fe3484c9b2d398e986f5 GIT_BRANCH=release-3.5.1 GIT_TAG=v3.5.1 GIT_TREE_STATE=dirty RELEASE_TAG=true DEV_BRANCH=false VERSION=v3.5.1
KUBECTX= DOCKER_DESKTOP=false K3D=false DOCKER_PUSH=false
RUN_MODE=local PROFILE=minimal AUTH_MODE=hybrid SECURE=false STATIC_FILES=true ALWAYS_OFFLOAD_NODE_STATUS=false UPPERIO_DB_DEBUG=0 LOG_LEVEL=debug NAMESPACED=trueCGO_ENABLED=0 go build -v -gcflags '' -ldflags '-X github.com/argoproj/argo-workflows/v3.version=v3.5.1 -X github.com/argoproj/argo-workflows/v3.buildDate=2024-01-01T17:15:27Z -X github.com/argoproj/argo-workflows/v3.gitCommit=877c5523066e17687856fe3484c9b2d398e986f5 -X github.com/argoproj/argo-workflows/v3.gitTreeState=dirty -X github.com/argoproj/argo-workflows/v3.gitTag=v3.5.1 -extldflags -static' -o dist/argoexec ./cmd/argoexec
workflow\executor\os-specific\signal_linux.go:1:1: expected 'package', found signal_darwin
make: *** [Makefile:237: dist/argoexec] Error 1

Version

3.5.0+

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

.

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
@tczhao tczhao added type/bug type/regression Regression from previous behavior (a specific type of bug) labels Feb 1, 2024
@agilgur5 agilgur5 added area/executor P3 Low priority labels Feb 1, 2024
@tczhao tczhao changed the title Make argoexec-image returns error in Windows Make argoexec-image returns error in Windows expected 'package', found signal_darwin Feb 1, 2024
@agilgur5 agilgur5 added the area/build Build or GithubAction/CI issues label Feb 1, 2024
@agilgur5
Copy link

Closing per #12604 (comment)

@agilgur5 agilgur5 changed the title Make argoexec-image returns error in Windows expected 'package', found signal_darwin make argoexec-image returns error in Windows expected 'package', found signal_darwin Apr 26, 2024
@agilgur5 agilgur5 added the area/windows Windows Container support label Jun 6, 2024
@agilgur5 agilgur5 added the area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix label Jul 19, 2024
@agilgur5
Copy link

Apparently this is indeed duplicative of #9590 and a general error when symlinks are not enabled in git

@agilgur5 agilgur5 added the solution/duplicate This issue or PR is a duplicate of an existing one label Aug 31, 2024
@argoproj argoproj locked as resolved and limited conversation to collaborators Aug 31, 2024
@agilgur5 agilgur5 added the solution/workaround There's a workaround, might not be great, but exists label Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/build Build or GithubAction/CI issues area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix area/executor area/windows Windows Container support P3 Low priority solution/duplicate This issue or PR is a duplicate of an existing one solution/workaround There's a workaround, might not be great, but exists type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants