fix: consistently set executor log options #12979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
commented
Apr 24, 2024
tczhao
reviewed
May 1, 2024
|
You mean making this line more specific? I didn't change the option in this PR, just made it actually used, but could improve that for sure, especially as it is for the |
|
Merged |
added 7 commits
October 28, 2024 16:48
- for all commands, including `emissary`, `agent`, `resource`, and `data` - set loglevel, gloglevel, and log format - replace `getExecutorLogLevel` helper with `getExecutorLogOpts` helper - also add a helper in `/util/cmd` to get the gloglevel Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
agilgur5
force-pushed
the
fix-exec-log-opts
branch
from
2781ddf to
26ff9c6
Compare
|
Rebased and fixed a good chunk of merge conflicts since this has been waiting for review 6+ months now 😕 @tczhao @terrytangyuan could one of you review this? The PR has 3 upvotes now too
I can also do this in a separate PR, it's a bit orthogonal to this fix |
tczhao
approved these changes
Nov 5, 2024
Joibel
pushed a commit
that referenced
this pull request
Nov 22, 2024
Signed-off-by: Anton Gilgur <[email protected]> (cherry picked from commit 217b598)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12788, Fixes #12929 (comment)
Motivation
Modifications
for all commands, including
emissary,agent,resource, anddatareplace
getExecutorLogLevelhelper withgetExecutorLogOptshelperadd a helper in
util/cmd/glog.goto get the gloglevelVerification
Existing tests pass