set WatchListPageSize when WatchError

[fyp711]

Pre-requisites

• I have double-checked my configuration
• I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
• I have searched existing issues and could not find a match for this bug
• I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?

This submission is an optimization based on this #11343
Optimize two key points:

1. Only set to empty when resourceVersion = 0
2. Set the WatchListPageSize property to ensure pagination

Version(s)

3.4.9

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

None

Logs from the workflow controller

None

Logs from in your workflow's wait container

None

[fyp711]

Could someone help review this? #13466 Thanks!

[fyp711]

Setting WatchListPageSize can better ensure the use of pagination queries.

Below code is a part of reflector.go.

         ...
	switch {
	case r.WatchListPageSize != 0:
		pager.PageSize = r.WatchListPageSize
	case r.paginatedResult:
		// We got a paginated result initially. Assume this resource and server honor
		// paging requests (i.e. watch cache is probably disabled) and leave the default
		// pager size set.
	case options.ResourceVersion != "" && options.ResourceVersion != "0":
		// User didn't explicitly request pagination.
		//
		// With ResourceVersion != "", we have a possibility to list from watch cache,
		// but we do that (for ResourceVersion != "0") only if Limit is unset.
		// To avoid thundering herd on etcd (e.g. on master upgrades), we explicitly
		// switch off pagination to force listing from watch cache (if enabled).
		// With the existing semantic of RV (result is at least as fresh as provided RV),
		// this is correct and doesn't lead to going back in time.
		//
		// We also don't turn off pagination for ResourceVersion="0", since watch cache
		// is ignoring Limit in that case anyway, and if watch cache is not enabled
		// we don't introduce regression.
		pager.PageSize = 0
	}

	list, paginatedResult, err = pager.List(context.Background(), options)
	...