feat(ui): Adjust the node display name to include which template is invoking it. Fixes #11106 #13509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrien Delannoy <[email protected]>
|
Looks like this was combined and superseded by #13511. When closing an issue or PR, please make sure to state the reason for it and add any links if relevant. |
agilgur5
added
area/ui
solution/superseded
|
Sure I will do that next time. It was indeed combined and superseded by #13511. The reason was that the modified code amount was small and was very similar so it can be reviewed in one time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11106. This is 1/2 PR, the 2/2 will be the grouping/collapse PR.
Motivation
It's confusing to look at the Workflows graph with templateRef and tasks having the same names
Modifications
I added the ability to show the invoking template name on nodes. To keep the actual display, I added the switch button on the toolbar.
Also updated the title to include the full id and name of the node as the test is truncated.
Demo
Screen.Recording.2024-08-27.at.11.11.30.mov
Verification
See screen recording