fix: aggregate JSON output parameters correctly

[Joibel]

Motivation

Fixes #13510

Modifications

outputs.result of a withItems/withParams will be conditionally json.Marshaled.

Other output parameters are always json.Marshalled, which leads to inconsitency and a complete inability to pass JSON out of withItems outputs straight back in as withItems

Conditionally Marshal the outputs.params

• avoiding it if the parameter isn't enclosed in { or [, primarily to avoid bare numbers as they're valid JSON but need quoting here
• falling back to old behaviour if this fails

Verification

Additional e2e test tests the example case.

[agilgur5]

@Joibel is this at all impacted by #12909? Since that creates a diff between main and 3.5 with JSON in templates

Briefly looking at the code, I don't think it does since it only impacts output parameters, but wanted to double check, especially since #12909 (comment) is still incomplete

[Joibel]

No, this isn't overlapping, and wouldn't be if #12909 had the remaining changes which are mostly around docs.

#13532 also doesn't appear to overlap, but does seem to have a similar cause. I haven't had a chance to see what's happening there though.

[agilgur5]

No, this isn't overlapping

Thanks just wanted to make sure!

and wouldn't be if #12909 had the remaining changes which are mostly around docs.

There were some edge cases there that hadn't been tested (that I had asked tests to be added for), and if those edge cases are impacted, we might want to change the logic. A variable already being JSON or already converted to JSON was one of those, hence my concern here

Do you want me to write up an issue to handle the remaining changes to track? I was going to do so if it hadn't been handled soon so that we don't forget about it

[agilgur5]

Do you want me to write up an issue to handle the remaining changes to track? I was going to do so if it hadn't been handled soon so that we don't forget about it

Went ahead and created an issue for it: #13541

[isubasinghe]

LGTM