Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump esbuild-loader, express, path-to-regexp, send, serve-static #13603

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 14, 2024

Bumps the deps group in /ui with 4 updates: express, path-to-regexp, send and serve-static.

Updates express from 4.19.2 to 4.21.0

Release notes

Sourced from express's releases.

4.21.0

What's Changed

New Contributors

Full Changelog: expressjs/express@4.20.0...4.21.0

4.20.0

What's Changed

Important

  • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect

Other Changes

... (truncated)

Changelog

Sourced from express's changelog.

4.21.0 / 2024-09-11

4.20.0 / 2024-09-10

  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • add depth option to customize the depth level in the parser
    • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect
  • deps: [email protected]
    • Adds support for named matching groups in the routes using a regex
    • Adds backtracking protection to parameters without regexes defined
  • deps: encodeurl@~2.0.0
    • Removes encoding of \, |, and ^ to align better with URL spec
  • Deprecate passing options.maxAge and options.expires to res.clearCookie
    • Will be ignored in v5, clearCookie will set a cookie with an expires in the past to instruct clients to delete the cookie
Commits

Updates path-to-regexp from 0.1.7 to 0.1.10

Release notes

Sourced from path-to-regexp's releases.

Backtrack protection

Fixed

  • Add backtrack protection to parameters 29b96b4
    • This will break some edge cases but should improve performance

pillarjs/path-to-regexp@v0.1.9...v0.1.10

Support non-lookahead regex output

Added

  • Allow a non-lookahead regex (#312) c4272e4

component/path-to-regexp@v0.1.8...v0.1.9

Support named matching groups in RegExp

Added

  • Add support for named matching groups (#301) 114f62d

pillarjs/path-to-regexp@v0.1.7...v0.1.8

Commits

Updates send from 0.18.0 to 0.19.0

Release notes

Sourced from send's releases.

0.19.0

What's Changed

New Contributors

Full Changelog: pillarjs/send@0.18.0...0.19.0

Changelog

Sourced from send's changelog.

0.19.0 / 2024-09-10

  • Remove link renderization in html while redirecting
Commits
Maintainer changes

This version was pushed to npm by ulisesgascon, a new releaser for send since your current version.


Updates serve-static from 1.15.0 to 1.16.2

Release notes

Sourced from serve-static's releases.

1.16.0

What's Changed

New Contributors

Full Changelog: expressjs/serve-static@v1.15.0...1.16.0

Changelog

Sourced from serve-static's changelog.

1.16.2 / 2024-09-11

  • deps: encodeurl@~2.0.0

1.16.1 / 2024-09-11

1.16.0 / 2024-09-10

  • Remove link renderization in html while redirecting
Commits
Maintainer changes

This version was pushed to npm by wesleytodd, a new releaser for serve-static since your current version.


You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added javascript Pull requests that update Javascript dependencies type/dependencies PRs and issues specific to updating dependencies labels Sep 14, 2024
@github-actions github-actions bot enabled auto-merge (squash) September 14, 2024 22:33
Bumps the deps group in /ui with 4 updates: [express](https://github.com/expressjs/express), [path-to-regexp](https://github.com/pillarjs/path-to-regexp), [send](https://github.com/pillarjs/send) and [serve-static](https://github.com/expressjs/serve-static).


Updates `express` from 4.19.2 to 4.21.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

Updates `path-to-regexp` from 0.1.7 to 0.1.10
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.7...v0.1.10)

Updates `send` from 0.18.0 to 0.19.0
- [Release notes](https://github.com/pillarjs/send/releases)
- [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md)
- [Commits](pillarjs/send@0.18.0...0.19.0)

Updates `serve-static` from 1.15.0 to 1.16.2
- [Release notes](https://github.com/expressjs/serve-static/releases)
- [Changelog](https://github.com/expressjs/serve-static/blob/v1.16.2/HISTORY.md)
- [Commits](expressjs/serve-static@v1.15.0...v1.16.2)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
  dependency-group: deps
- dependency-name: path-to-regexp
  dependency-type: indirect
  dependency-group: deps
- dependency-name: send
  dependency-type: indirect
  dependency-group: deps
- dependency-name: serve-static
  dependency-type: indirect
  dependency-group: deps
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/ui/deps-f062349243 branch from 24a4530 to e1506ed Compare September 19, 2024 15:03
Signed-off-by: Anton Gilgur <[email protected]>
@agilgur5 agilgur5 changed the title chore(deps): bump the deps group in /ui with 4 updates chore(deps-dev): bump express, path-to-regexp, send, and serve-static in yarn.lock Oct 28, 2024
Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all devDeps, not prod deps, so I've reworded the title.

The CI error is regarding dep deduplication, so will push a commit to automatically deduplicate via yarn deduplicate

@agilgur5
Copy link

Oh and one of the transitive deps is causing a new build error:

Error: File '@ljharb/tsconfig' not found.
    at Be (/home/runner/work/argo-workflows/argo-workflows/ui/node_modules/get-tsconfig/dist/index.cjs:3:9201)
    at ie (/home/runner/work/argo-workflows/argo-workflows/ui/node_modules/get-tsconfig/dist/index.cjs:3:10245)
    at le (/home/runner/work/argo-workflows/argo-workflows/ui/node_modules/get-tsconfig/dist/index.cjs:3:10975)
    at Object.Le [as getTsconfig] (/home/runner/work/argo-workflows/argo-workflows/ui/node_modules/get-tsconfig/dist/index.cjs:3:11080)
    at Object.ESBuildLoader (/home/runner/work/argo-workflows/argo-workflows/ui/node_modules/esbuild-loader/dist/index.cjs:65:36)
    at LOADER_EXECUTION (/home/runner/work/argo-workflows/argo-workflows/ui/node_modules/loader-runner/lib/LoaderRunner.js:132:[14](https://github.com/argoproj/argo-workflows/actions/runs/11562774576/job/32185162783?pr=13603#step:5:15))
    at runSyncOrAsync (/home/runner/work/argo-workflows/argo-workflows/ui/node_modules/loader-runner/lib/LoaderRunner.js:133:4)
    at iterateNormalLoaders (/home/runner/work/argo-workflows/argo-workflows/ui/node_modules/loader-runner/lib/LoaderRunner.js:251:2)
    at /home/runner/work/argo-workflows/argo-workflows/ui/node_modules/loader-runner/lib/LoaderRunner.js:224:4
    at /home/runner/work/argo-workflows/argo-workflows/ui/node_modules/webpack/lib/NormalModule.js:980:[15](https://github.com/argoproj/argo-workflows/actions/runs/11562774576/job/32185162783?pr=13603#step:5:16)

See privatenumber/esbuild-loader#363, need to upgrade esbuild-loader

@agilgur5 agilgur5 disabled auto-merge October 28, 2024 21:36
@agilgur5 agilgur5 changed the title chore(deps-dev): bump express, path-to-regexp, send, and serve-static in yarn.lock chore(deps-dev): bump esbuild-loader, express, path-to-regexp, send, serve-static Oct 28, 2024
Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 2 different build issues and passes now. Changes LGTM as well

@agilgur5 agilgur5 added the type/security Security related label Oct 28, 2024
@agilgur5 agilgur5 enabled auto-merge (squash) October 28, 2024 21:42
@agilgur5 agilgur5 merged commit 1b60638 into main Oct 28, 2024
17 checks passed
@agilgur5 agilgur5 deleted the dependabot/npm_and_yarn/ui/deps-f062349243 branch October 28, 2024 21:43
@agilgur5
Copy link

agilgur5 commented Oct 28, 2024

These are all devDeps, not prod deps, so I've reworded the title.

Dependabot seems to be unable to determine our devDeps despite being configured to. As it only updates and seems to look at the yarn.lock, my guess is that maybe because the yarn.lock does not itself distinguish between the two types (only the package.json does)

@agilgur5 agilgur5 removed the type/security Security related label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant