Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-to-protobuf needs to be updated to the latest version #13620

Open
blkperl opened this issue Sep 18, 2024 · 1 comment
Open

go-to-protobuf needs to be updated to the latest version #13620

blkperl opened this issue Sep 18, 2024 · 1 comment
Labels
area/build Build or GithubAction/CI issues go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies type/tech-debt

Comments

@blkperl
Copy link
Contributor

blkperl commented Sep 18, 2024

Summary

In #13413, #12847, and #12822 go-to-protobuf was missed or was unable to be updated to the latest K8s version. The current error message is the following when running make pre-commit -B

Unable to clean package k8s.io.api.core.v1: remove /home/runner/go/pkg/mod/k8s.io/[email protected]/core/v1/generated.proto: permission denied

argo-workflows/Makefile

Lines 306 to 308 in 53e5461

# TODO: currently fails on v0.30.3 with
# Unable to clean package k8s.io.api.core.v1: remove /home/runner/go/pkg/mod/k8s.io/[email protected]/core/v1/generated.proto: permission denied
go install k8s.io/code-generator/cmd/[email protected]

Use Cases

The use case for upgrading is to ensure we don't have any strange behavior

Message from the maintainers:

Love this feature request? Give it a 👍. We prioritise the proposals with the most 👍.
@blkperl blkperl added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies labels Sep 18, 2024
@agilgur5
Copy link

Related: #13542

@agilgur5 agilgur5 changed the title go-to-protobuf needs to be updated to the latest version go-to-protobuf needs to be updated to the latest version Sep 18, 2024
@agilgur5 agilgur5 added type/tech-debt area/build Build or GithubAction/CI issues labels Sep 18, 2024
qingfeng777 added a commit to qingfeng777/argo-workflows that referenced this issue Sep 24, 2024
@qingfeng777
fix(build): upgrade go-to-protobuf version to v0.30.5. (argoproj#13620)
b2c0662 
Signed-off-by: qingfeng777 <[email protected]>
@qingfeng777 qingfeng777 mentioned this issue Sep 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build Build or GithubAction/CI issues go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies type/tech-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: upgrade go-to-protobuf to v0.30.5. Fixes #13620 qingfeng777/argo-workflows
2 participants
@blkperl @agilgur5