Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for CronWorkflows when #13700

Closed
Joibel opened this issue Oct 3, 2024 · 2 comments · Fixed by #13723
Closed

Add docs for CronWorkflows when #13700

Joibel opened this issue Oct 3, 2024 · 2 comments · Fixed by #13723
Labels
area/cron-workflows area/docs Incorrect, missing, or mistakes in docs type/feature Feature request
Milestone
v3.6.x patches

Comments

@Joibel
Copy link
Member

Joibel commented Oct 3, 2024

Summary

The 3.6 feature when for CronWorkflows has no documentation of the actual when clause.

The new variables are documented in #13474 but the field is not.
@Joibel Joibel added type/feature Feature request area/docs Incorrect, missing, or mistakes in docs labels Oct 3, 2024
@agilgur5 agilgur5 changed the title docs: CronWorkflows when expression has no documentation Add docs for CronWorkflows when Oct 3, 2024
@agilgur5 agilgur5 added this to the v3.6.0 milestone Oct 3, 2024
@agilgur5
Copy link

agilgur5 commented Oct 3, 2024 •
edited
Loading

We can refer to the existing when documentation and the new examples from this new section for simplicity and consistency

@Joibel
Copy link
Member Author

Joibel commented Oct 7, 2024 •
edited by agilgur5
Loading

I specifically mean this options table (badly titled?) doesn't mention when and must.

@Joibel Joibel mentioned this issue Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cron-workflows area/docs Incorrect, missing, or mistakes in docs type/feature Feature request
Projects
None yet
Milestone
v3.6.x patches
Development

Successfully merging a pull request may close this issue.

docs(cron): add when to table + examples for DST leap handling pipekit/argo-workflows
3 participants
@Joibel @agilgur5 @isubasinghe